Merged
Conversation
added 4 commits
May 8, 2017 13:58
We check for liblustreapi.h in OMPI_CHECK_LUSTRE, so this code was commented out here. Might as well fully delete it, since it's redundant and dead. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit c81bc50) Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Make sure the default Autoconf "yes" value for $with_lustre when the user specifies --with-lustre on the command line (without a value) does not propagate down into the directory logic. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 8604273) Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Minor style updates; nothing of real consequence. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit eb89712) Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Follow the OMPI bias: if a human requests feature X and configure can't deliver feature X, abort and let the human figure it out. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit c119759) Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Contributor
|
There isn't a rush on my part to get this fix into 2.1.1, since my workaround of just specifying --with-luster=/usr worked for my immediate situation. My concern is just that it should get fixed so others don't get avoidable build errors in this regard. |
edgargabriel
approved these changes
May 10, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding master PR: #3455
Several
--with-lustreconfigury fixes. See #3455 for explanation.@edgargabriel Can you review? Thanks.
@edgargabriel @timattox Do we feel strongly that this fix should go into v2.1.1? Or is it ok to slip to v2.1.2?